phundrak/p4bl0t
phundrak
/
p4bl0t
1
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects 2 Releases Wiki Activity

WIP: feat: add a channel as a logging channel #5

Closed
phundrak wants to merge 0 commits from develop into feature/add-new-logging-channels
pull from: develop
merge into: phundrak:feature/add-new-logging-channels
Conversation 0 Commits - Files Changed -
phundrak commented 2023-11-23 01:13:54 +00:00
Owner
Copy Link

To enhance:

  • Correctly handle errors from database
    Currently, when adding twice a channel, we get a message like so:

    error returned from database: (code: 2067) UNIQUE constraint failed: guild_log_channels.guild_id, guild_log_channels.channel_id

  • Verify non-admin users cannot use the command
  • Write tests
To enhance: - Correctly handle errors from database Currently, when adding twice a channel, we get a message like so: > error returned from database: (code: 2067) UNIQUE constraint failed: guild_log_channels.guild_id, guild_log_channels.channel_id - Verify non-admin users cannot use the command - Write tests
phundrak added this to the 1.0.0 milestone 2023-11-23 01:25:19 +00:00
phundrak closed this pull request 2023-11-23 02:03:43 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
1.0.0
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: phundrak/p4bl0t#5
No description provided.
Delete Branch "develop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?