phundrak/p4bl0t
1
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects 2 Releases Wiki Activity

WIP: feat: add a channel as a logging channel #5

Closed
phundrak wants to merge 0 commits from develop into feature/add-new-logging-channels
pull from: develop
merge into: :feature/add-new-logging-channels
Conversation 0 Commits - Files Changed -
phundrak commented 2023-11-23 02:13:54 +01:00
Owner
Copy Link
Copy Source

To enhance:

  • Correctly handle errors from database
    Currently, when adding twice a channel, we get a message like so:

    error returned from database: (code: 2067) UNIQUE constraint failed: guild_log_channels.guild_id, guild_log_channels.channel_id

  • Verify non-admin users cannot use the command
  • Write tests
To enhance: - Correctly handle errors from database Currently, when adding twice a channel, we get a message like so: > error returned from database: (code: 2067) UNIQUE constraint failed: guild_log_channels.guild_id, guild_log_channels.channel_id - Verify non-admin users cannot use the command - Write tests
phundrak added this to the 1.0.0 milestone 2023-11-23 02:25:19 +01:00
phundrak closed this pull request 2023-11-23 03:03:43 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone 1.0.0
Projects
Clear projects
No projects
Assignees
Clear assignees
phundrak (Lucien Cartier-Tilet)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: phundrak/p4bl0t#5