phundrak/phundrak.com
1
0
Fork 0
Code Issues Pull Requests Actions Activity

[Bug] API calls made twice through ApiLoader #1

New Issue
Closed
opened 2023-09-22 14:14:42 +00:00 by phundrak · 1 comment
phundrak commented 2023-09-22 14:14:42 +00:00
Owner
Copy Link

Due to the behaviour of Cache.vue and ApiLoader.vue, any call to an API is made twice. A fix would be to simply pipe the API response in the Cache.vue component instead of subscribing to its observer.

Due to the behaviour of [`Cache.vue`](https://labs.phundrak.com/phundrak/phundrak.com/src/commit/be09cf68d5b003d06f290872900a943237033cbb/content/.vuepress/components/Cache.vue#L43) and [`ApiLoader.vue`](https://labs.phundrak.com/phundrak/phundrak.com/src/commit/be09cf68d5b003d06f290872900a943237033cbb/content/.vuepress/components/ApiLoader.vue#L54), any call to an API is made twice. A fix would be to simply pipe the API response in the `Cache.vue` component instead of subscribing to its observer.
phundrak added the
bug
 label 2023-09-22 14:14:42 +00:00
phundrak self-assigned this 2023-09-22 14:14:42 +00:00
phundrak commented 2023-11-03 19:19:12 +00:00
Author
Owner
Copy Link

Fixed in 2496bff82f

Fixed in 2496bff82f04fbb5ec825a06640608ccdfb4fe27
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
phundrak
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: phundrak/phundrak.com#1
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?