phundrak/nord-for-org
Archived
1
0
Fork 0
Code Issues 1 Pull Requests Releases 4 Activity

Dropdowns won’t work on browsers based on webkit #9

New Issue
Closed
opened 2020-05-22 18:39:37 +00:00 by phundrak · 2 comments
phundrak commented 2020-05-22 18:39:37 +00:00
Owner
Copy Link

For some reasons, dropdowns don’t work on webkit-based browsers such as Safari or Surf. I suspect it is due to the :focus-within pseudo-class being badly handled by the engine. A fix for this could be to use a .hidden class in the elements that are to be hidden. This class could be removed on a list click, and added back when another click is detected on the document. The element could stay shown with the :focus pseudo-class on the drop-down.

For some reasons, dropdowns don’t work on webkit-based browsers such as Safari or Surf. I suspect it is due to the `:focus-within` pseudo-class being badly handled by the engine. A fix for this could be to use a `.hidden` class in the elements that are to be hidden. This class could be removed on a list click, and added back when another click is detected on the document. The element could stay shown with the `:focus` pseudo-class on the drop-down.
phundrak added the
bug
 label 2020-05-22 18:39:37 +00:00
phundrak commented 2020-07-26 19:21:44 +00:00
Author
Owner
Copy Link

After much research, sweat, tears, and blood, I finally came across this blog post which finally gave me the key for fixing this god awful implementation of :focus-within that plagues WebKit. A commit should be pushed in the next few minutes to fix this awful bug.

After much research, sweat, tears, and blood, I finally came across [this blog post](https://www.kizu.ru/keyboard-only-focus/) which finally gave me the key for fixing this god awful implementation of `:focus-within` that plagues WebKit. A commit should be pushed in the next few minutes to fix this awful bug.
phundrak referenced this issue from a commit 2020-07-26 19:24:25 +00:00
Finally fix issue #9
phundrak commented 2020-07-26 19:44:24 +00:00
Author
Owner
Copy Link

Fixed in commit 272bd93ed8. Closing.

Fixed in commit 272bd93ed8. Closing.
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
good first issue

Easy to fix issues

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: phundrak/nord-for-org#9
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?