feat: display API errors

This commit is contained in:
2023-05-08 18:04:30 +02:00
parent c026ed4c6f
commit 89d2e1b9b3
5 changed files with 42 additions and 10 deletions

View File

@@ -8,15 +8,16 @@
<slot v-if="loading" name="loader">
<Loader />
</slot>
<slot v-else-if="error" name="error"></slot>
<slot v-else>
{{ error }}
<slot v-else-if="error" name="error">
<Error :url="props.url" />
</slot>
<slot v-else> </slot>
</template>
<script setup lang="ts">
import Cache from './Cache.vue';
import Loader from './Loader.vue';
import Error from './Error.vue';
import { Ref, ref } from 'vue';
import { Observable, catchError, switchMap, throwError } from 'rxjs';
@@ -42,9 +43,9 @@ const loading: Ref<boolean> = ref(true);
const fetchData = (): Observable<any> => {
return fromFetch(props.url).pipe(
switchMap((response: Response) => response.json()),
catchError((error: Error) => {
console.error(error);
return throwError(() => new Error(error.message));
catchError((errorResponse: Error) => {
error.value = errorResponse;
return Error;
})
);
};
@@ -62,5 +63,3 @@ const processCachedData = (data: Observable<any>) => {
});
};
</script>
<style lang="less"></style>

View File

@@ -0,0 +1,26 @@
<template>
<div class="error rounded-corners card-width">
<p>API call to {{ props.url }} failed</p>
</div>
</template>
<script setup lang="ts">
const props = defineProps({
url: {
required: true,
type: String,
},
});
</script>
<style lang="less">
@import 'node_modules/nord/src/lesscss/nord.less';
@import '../styles/classes.less';
.error {
display: inline-block;
padding: 2rem;
text-align: center;
background: @nord11;
}
</style>

View File

@@ -1,5 +1,7 @@
<template>
<div class="githubRepo flex-col flex-space-between gap-1rem rounded-corners">
<div
class="githubRepo flex-col flex-space-between gap-1rem rounded-corners card-width"
>
<ApiLoader
:cache-name="repoName()"
:url="fetchUrl"
@@ -51,7 +53,6 @@ const repository: Ref<GithubRepo> = ref(null);
@import '../../styles/classes.less';
.githubRepo {
max-width: 35rem;
padding: 2rem;
background-color: @nord4;
align-self: auto;