phundrak/bakit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(contact): ignore empty honeypot values even if String exists

Browse Source
This commit is contained in:
Lucien Cartier-Tilet
2025-11-27 15:39:36 +01:00
parent 03bd411c18
commit 08861562bc
2 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/route/contact/errors.rs
View File

@@ -93,10 +93,14 @@ impl From<ValidationErrors> for ContactError {
return Self::ValidationNameError("backend.contact.errors.validation.name".to_owned()); return Self::ValidationNameError("backend.contact.errors.validation.name".to_owned());
} }
if validator::ValidationErrors::has_error(&Err(value.clone()), "email") { if validator::ValidationErrors::has_error(&Err(value.clone()), "email") {
return Self::ValidationEmailError("backend.contact.errors.validation.email".to_owned()); return Self::ValidationEmailError(
"backend.contact.errors.validation.email".to_owned(),
);
} }
if validator::ValidationErrors::has_error(&Err(value), "message") { if validator::ValidationErrors::has_error(&Err(value), "message") {
return Self::ValidationMessageError("backend.contact.errors.validation.message".to_owned()); return Self::ValidationMessageError(
"backend.contact.errors.validation.message".to_owned(),
);
} }
Self::ValidationError("backend.contact.errors.validation.other".to_owned()) Self::ValidationError("backend.contact.errors.validation.other".to_owned())
} }
@@ -113,9 +117,13 @@ impl From<ContactError> for ContactResponse {
success: false, success: false,
message: match value { message: match value {
ContactError::CouldNotParseRequestEmailAddress(_) ContactError::CouldNotParseRequestEmailAddress(_)
| ContactError::ValidationEmailError(_) => "backend.contact.errors.validation.email", | ContactError::ValidationEmailError(_) => {
"backend.contact.errors.validation.email"
}
ContactError::ValidationNameError(_) => "backend.contact.errors.validation.name", ContactError::ValidationNameError(_) => "backend.contact.errors.validation.name",
ContactError::ValidationMessageError(_) => "backend.contact.errors.validation.message", ContactError::ValidationMessageError(_) => {
"backend.contact.errors.validation.message"
}
ContactError::CouldNotParseSettingsEmail(_) ContactError::CouldNotParseSettingsEmail(_)
| ContactError::FailedToBuildMessage(_) | ContactError::FailedToBuildMessage(_)
| ContactError::CouldNotSendEmail(_) | ContactError::CouldNotSendEmail(_)

4
src/route/contact/mod.rs
View File

@@ -161,7 +161,9 @@ impl ContactApi {
remote_addr: Option<poem::web::Data<&poem::web::RemoteAddr>>, remote_addr: Option<poem::web::Data<&poem::web::RemoteAddr>>,
) -> ContactApiResponse { ) -> ContactApiResponse {
let body = body.0; let body = body.0;
if body.honeypot.is_some() { if let Some(ref honeypot) = body.honeypot
&& !honeypot.trim().is_empty()
{
tracing::event!( tracing::event!(
target: "backend::contact", target: "backend::contact",
tracing::Level::INFO, tracing::Level::INFO,